Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] sale_commission_partial_settlement: partial_commission computation #585

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

aleuffre
Copy link

Fixes an error where with two computations. A partial reconciliation with no partial settlements linked previously counted as settled.

@OCA-git-bot
Copy link
Contributor

Hi @renda-dev, @PicchiSeba,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

Copy link
Contributor

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense and looks cleaner, thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-585-by-renda-dev-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3cf08a9 into OCA:14.0 Dec 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4ed5bc0. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-commission-partial-settled branch December 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants